https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43754 --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Open question on tax: which unit price should go on the items? A manual receive follows the vendor's "invoice prices include tax" setting (aqbooksellers.invoiceincgst). When it is set, the order's unitprice is the tax-included figure, otherwise the tax-excluded one (Koha::Acquisition::Order::populate_with_prices_for_receiving, acqui/parcel.pl), and acqui/finishreceive.pl copies that unitprice to items.price. process_invoice does not follow it. It always sets unitprice and unitprice_tax_included to the line total including tax (MOA+128 divided by the quantity), and unitprice_tax_excluded to the amount excluding tax (MOA+203 divided by the quantity), whatever the vendor setting is. The patch here copies the order's unitprice to items.price, so for a vendor whose invoice prices exclude tax an EDI receipt records a different price on the item, and a different unitprice on the order, from the same receipt done by hand. Proposal: follow Koha's existing settings (the vendor's invoiceincgst, and the system preferences that govern how acquisitions prices and fund values are handled) for what is stored, and add a vendor-level setting for the tax handling the supplier's message uses. We would then convert from what the message says to what Koha expects, rather than assuming one basis. The EDItEUR INVOIC gives both amounts (MOA+203 excluding tax, MOA+128 including it), so for a conforming supplier the conversion is only a choice of which one to use. The setting is needed for suppliers whose MOA codes do not follow that meaning. Whether this is done in this bug or a follow-up is open, as it changes the unitprice on the order as well as on the item. -- You are receiving this mail because: You are watching all bug changes.