http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #9)
Comment on attachment 41387 [details] [review] Bug 14639: Extend Koha::MetadataRecord to handle serialization format and record id
Review of attachment 41387 [details] [review]: -----------------------------------------------------------------
::: Koha/MetadataRecord.pm @@ +84,5 @@
+ + my $record = $params->{ record }; + my $schema = $params->{ schema } // 'marc21'; + my $format = $params->{ format } // 'MARC'; + my $id = $params->{ id };
Don't you think these 4 params should be mandatory? I would raise an exception if one of them is not given to the constructor.
I agree. But my plan was to do that on a later stage, so the transition into using this is more smooth. So for now I just fallback to the current behaviour. Once this is in, I will provide the relevant regression tests for an API change. Also, we need to get the exception handling code pushed before that too. -- You are receiving this mail because: You are watching all bug changes.