https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Joonas Kylmälä from comment #5)
(In reply to Kyle M Hall from comment #4)
Created attachment 91139 [details] [review] [review] Bug 23233: Remove use of AllowItemsOnHoldCheckout from Koha::Item::has_pending_hold, it can cause false data to be returned
Thanks. So just to summarize what this does: In koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc it is shown to patron whether the item is available for checkout and without this patch it actually showed whether it is available through SIP server and didn't consider it could have been available through intranet or SCO. This same bug seems to be in two other lines in the same Koha/Items.pm file:
C4/Items.pm: $query .= ",IF(tmp_holdsqueue.itemnumber,1,0) AS has_pending_hold" if !C4::Context->preference('AllowItemsOnHoldCheckout');
C4/Items.pm: LEFT JOIN tmp_holdsqueue USING (itemnumber)" if !C4::Context->preference('AllowItemsOnHoldCheckout');
Shouldn't those also be fixed?
You are absolutely right! Good catch :) I'll update my followup to include those changes. -- You are receiving this mail because: You are watching all bug changes.