https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40459 --- Comment #5 from CJ Lynce <cj.lynce@westlakelibrary.org> --- (In reply to Andrew Fuerste-Henry from comment #4)
This is odd because elsewhere in the patron record any value set in a field that gets hidden via BorrowerUnwantedField is saved forever and cannot be edited from the patron record. But following that behavior for preferred_name would cause problems for patrons who change their firstnames, as their preferred_name would not update --and as soon as firstname and preferred_name do not match, Koha starts displaying preferred_name around the intranet and OPAC.
Ideally, there would be a test to see if preferred_name is hidden BorrowerUnwantedField, and in that case, ignores, but doesnt change, the preferred_name field. This way, anything stored in preferred_name is preserved in the event its hidden then unhidden in the future. That said, without knowing exactly how preferred_name is handled throughout Koha, it is potentially a big undertaking to change this behavior. For the time being, though it doesn't really follow the behavior of other hidden/stored patron fields, the newdata{preferred_name} = undef unless defined $newdata{preferred_name} test helps to prevent a wrong preferred_name from being locked in if the field is hidden. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.