https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42383 --- Comment #43 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 209576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209576&action=edit Bug 42383: (QA follow-up) Close non-blocking transfer modals on click outside or Escape With TransfersBlockCirc disabled, the legacy returns.pl transfer modals had no static backdrop: clicking outside of them or pressing Escape closed them, and with AutomaticConfirmTransfer enabled closing them confirmed the transfer. On the Vue check-in page the only way out of a non-blocking transfer modal was one of its buttons, or scanning the next item. This patch makes ConfirmationModal emit 'close' when a non-blocking transfer modal gets a click outside of the dialog or an Escape key press. Main.vue then confirms the transfer if the checkin has one and AutomaticConfirmTransfer is enabled, and otherwise moves on leaving the transfer as it is. Blocking transfer modals (TransfersBlockCirc enabled) and the other modals are unchanged. Test plan: 1. Apply this patch and rebuild the JS: $ ktd --shell k$ yarn build 2. Set TransfersBlockCirc to "Don't block" and AutomaticConfirmTransfer to "Do" 3. Put an item in transit to library A, and check it in at library B (wrong transfer) => SUCCESS: The "Please return item to A" modal shows 4. Click anywhere outside of the modal => SUCCESS: The modal closes => SUCCESS: The item shows as in transit to A on its details page 5. Repeat 3, press Escape instead of clicking outside => SUCCESS: Same as step 4 6. Set AutomaticConfirmTransfer to "Don't" and repeat 3 and 4 => SUCCESS: The modal closes and the transfer is not sent 7. Click inside the modal (e.g. on its text) => SUCCESS: The modal stays open 8. Set TransfersBlockCirc to "Block" and repeat 3 and 4 => SUCCESS: The modal stays open until one of its buttons is used 9. Sign off :-D Assisted-by: Opus 5.5 (Anthropic) Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.