https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 Bug ID: 33611 Summary: Holds being placed in the future if DefaultHoldExpirationdate is set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 30718 altered C4::Reserves::AddReserve to use either the date passed in, or a dt_from_string object When storing the hold, we call Koha::Hold::_set_default_expirationdate This assumed reservedate was always a string, and used it to create a dt object, and add days for the expiration. Now that reservedate is already a dt object, this means we add the days to the object, so the reservedate is set into the future, as well as the expiration To recreate 1 - Set DefaultHoldExpiration to Set 2 - Set DefaultHoldExpirationPeriod to 365 3 - Set DefaultHoldExpirationunitOfTimeToDays 4 - Place a hold 5 - Note reserve date is 1 year in the future, same as expiration -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.