http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- A bit late to be sure there is no regression, but everything looks good. Just some minor notes:
t/db_dependent/BiblioObject.t
I would prefer a better filename, but nothing in mind to suggest.
+my $field_mappings = Koha::Database->new()->schema()->resultset('Fieldmapping');
Could be better to have a Koha::Fieldmapping[s]
- waiting_count => $wcount,
This variable is still used in the template.
+ WAITING => $reserves->waiting()
Why not remove this one and access to the waiting holds using RESERVES.waiting in the template? -- You are receiving this mail because: You are watching all bug changes.