https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33886 --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- (In reply to Brendan Lawlor from comment #18)
The native date input works really nice.
One small accessibility issue I found is that when focus is on the calendar icon, the enter key does not work as expected to open the date picker because of the class="noEnterSubmit"
I looked into it and it doesn't seem to work to remove the noEnterSubmit class where you remove the flatpicker class because of a line on members.js.
It could be fixed like this on prog/js/members.js line 288: - $("fieldset.rows input, fieldset.rows select").addClass("noEnterSubmit");
+ $("fieldset.rows input:not([type=date]), fieldset.rows select").addClass("noEnterSubmit");
I noticed this but didn't dig very deep.. I found 'space' worked to trigger the picker. Sounds like you dug a bit deeper and like there's a nicer alternative.
The other thing I found is that this also updates the Expiry date input to use the native html, but leaves the registration date as a flatpicker. Was that intentional? I think for consistency all three date inputs on the member entry page should work the same way.
Overall I like the move to using the native html date input, but the implementation is a little weird that it's still a flatpicker input in the template and it's just updated with js. I wonder what's the rational for that?
I was really trying to just fix the core issue as reported by the sponsor initially.. but community kept pushing and making this grow in different places.. honestly. I'd like to just outright drop flatpickr entirely at this point but I think that should be on it's own bug as I can see it taking a while for community to all agree to it.. but basically I agree entirely with what your saying.. I'd like ALL, not just on this page, date/datetime etc pickers to be consistent. -- You are receiving this mail because: You are watching all bug changes.