http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Kyle M Hall <kyle.m.hall@gmail.com> --- Thanks Olli! I do like your version ( except for the odd default value ; ). However it does break from the standard way of doing things in cleanup_database. That being said, if you *were* to add a unit test I'd say that would be a worthwhile improvement and I'd be more than happy to deprecate my version and sign off on yours! -- You are receiving this mail because: You are watching all bug changes.