http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8738 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- MJ, can you please provide us with a scenario that will produce the error you describe in comment 1? You tell us to prove this is not a bug. That seems a bit backwards, don't you think? I just want to be able to reproduce your error, and prove this patch fixes it with no new errors or bad behavior. Kyle (In reply to comment #6)
Well, it's great that it works for you, but it's erroring for some libraries.
I suspect this might only present itself on upgrades where the circulation history meets some combination of conditions, but I have met it three times on different servers at different libraries so far: one we installed, one we upgraded and one we only support after they met this.
In theory, it looks like a type error to me. Can you see how that circ/circulation.pl line http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=circ/circulation. pl;h=f15d4cea94e67e74b6c87ccbef50d0c572b658d1;hb=HEAD#l469 isn't comparing a DateTime to a string, or explain why that isn't a bug?
In the first comparison in that line:
$it->{'issuedate'} is a DateTime returned by C4::Members::GetPendingIssues(...) since the addition of hourly loans. http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Members.pm; h=b2f45b955bf3ff3ba57457ca6ec2130fb38021ec;hb=HEAD#l1039
$todaysdate is a string returned by C4::Dates->new->output('iso') http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Dates.pm; h=4fd08aeb6c4e94a744652b321202d313cd531eb5;hb=HEAD#l184
At best, if this fix doesn't break your test copies in practice and you can't see a theoretical problem with it, could we include it, please?
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.