https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #191 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Comment on attachment 81284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81284 Bug 19893: Add pods, remove syspref, add tests for serialization format Review of attachment 81284: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19893&attachment=81284) ----------------------------------------------------------------- ::: Koha/SearchEngine/Elasticsearch.pm @@ +592,5 @@
+rules keyed by MARC field tags holding all the mapping rules for that particular tag. + +We can then iterate through all MARC fields for each record and apply all relevant +rules once per fields instead of retreiving fields multiple times for each mapping rule +wich is terribly slow.
wich -> which @@ +605,5 @@
+sub _get_marc_mapping_rules { + my ($self) = @_; + + my $marcflavour = lc C4::Context->preference('marcflavour'); + my @rules;
There are now two definitions for rules variable. Let's remove this first one. @@ +699,4 @@
push @{$rules->{leader}}, @mappings; } else { + die("Invalid MARC field: $marc_field");
https://wiki.koha-community.org/wiki/Coding_Guidelines#Perl says "Instead of die or croak when meeting unfavorable conditions in our code, we should raise exceptions via Koha::Exceptions. " There is also "die("Unmatched opening parenthesis for $marc_field");" and maybe others that need to be fixed -- You are receiving this mail because: You are watching all bug changes.