https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26517 --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- $patron->set({ flags => 0 })->store;(In reply to Katrin Fischer from comment #7)
Hm, a few small things:
1) if a user has only subpermissions, flags are 0. Should we extend the check to take care of these? I could imagine someone removing catalog permission for someone temporarily not working at the library, but expected to return. Ich, another problem from this strange permissions storage.
2) I think all the tests for GetBororwersToExpunge should be grouped into a subtest (but this was an issue before your patch) Agreed. I'll try to find some time to patch.
3) All patrons I see in the tests have flags = undef... am I missing the one blocked from deleting for flags? In tests I add I use : $patron->set({ flags => 4 })->store. I add in other tests flags => undef for them to pass, otherwise the value is random.
-- You are receiving this mail because: You are watching all bug changes.