https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42398 --- Comment #3 from Jan Kissig <bibliothek@th-wildau.de> --- (In reply to David Nind from comment #2)
I attempted to test, but I am leaving to someone else who understands the issue and what the change is that is required (and what is actually changed that is noticeable).
The only comment I'd make is if fields are required, then they should marked as such in the user interface.
Testing notes (using KTD): 1. Step 1d: - For the first group, I end up back on holdings table - For the second group I create, I end up on the item groups tab - I don't see the URL described (even looking at the dev tools, network options) 2. Step 2h: neither the default title or content are marked as required 3. After the patch: - For holds group, no difference noted - For adding news items, browser pop-up windows say that values are required for fields: note - none of the fields are marked as required
Hey David, seems problem 1 (Item groups) got solved with Bug 41566: Restore item groups ft There the validate() function call was moved outside the '$(document).ready()' block whichs seems to fix the problem. Interestingly this solution would also fix the issue on 2 (Additional contents 'news'). I will check on this and also fix the missing 'required' flags you mentioned. The origin of the problem seems to be the order when validate is called: this does not work: - staff-global.js calls validate() on all items class 'validated' - $(document).ready -> $(form).validate({submitHandler}) but calling in this order works: - $(form).validate({submitHandler}) - staff-global.js calls validate() on all items class 'validated' -- You are receiving this mail because: You are watching all bug changes.