http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> ---
You only add the new permissoins to the English files, which means they will not be available for anyone using not the English sample files. Could you add them to the other languages as well please? You don't have to translate the descriptions - translators will take care of it. But this way functionality is there and it's easier to fix a missing translation than to figure out a missing permission.
Will do.
I found some other minor things, but wanted to note them:
Another request I have would be to add some documentation to your new tables - I am sure Nicole would get to it sometime, but I think it would much easier for you to do.
Will do. I'll just add the documentation to the body of my followup patch.
Some of the templates don't follow the capitalization rules (example: Course Reserves)
Will do.
I am wondering about some changes that don't seem to belong to the course reserves module:
Example: maninvoice.tt: //<![CDATA[ $(document).ready(function(){ - $("fieldset.rows input").keydown(function(e){ return checkEnter(e); }); + $("fieldset.rows input").addClass("noEnterSubmit");
Can you explain why the change? Maybe this should be a separate bug as it seems to change a general pattern that is used in different files.
Please look at comments 24 and 25. -- You are receiving this mail because: You are watching all bug changes.