https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #47 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This is not yet ready (see last comment): Set noissuescharge to 0, I cannot checkout: 120NUN20160428 194310AORMA|AA2|AB123|AJMastering Perl /|AH|AFPatron Blocked|BLY| Note: CanBookBeIssued does checks like $non_issue_charges > $amountlimit==noissuescharge This is not exactly the same as: $fines_amount < C4::Context->preference('noissuescharge') Similarly, opac-user checks the renewal amount like: defined($no_renewal_amt) && $borr->{amountoutstanding} > $no_renewal_amt Different than just $fines_amount < C4::Context->preference('OPACFineNoRenewals') BTW Found this sql in Members.pm: $sth = $dbh->prepare("SELECT SUM(amountoutstanding) FROM accountlines WHERE borrowernumber = ?"); This is actually the same as GetTotalFines does. Are we using this more? Should we add a (simple) unit test for the new routine? Failed QA -- You are receiving this mail because: You are watching all bug changes.