https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160805|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160821&action=edit Bug 35536: Reorder rollbacks Time to move all RemovePlugins calls BEFORE rollbacks. Broken.t did not even include a transaction! Some modules are removed there as well. Test plan: Search for wrong order with: grep -Pzo "txn_rollback;\n.*RemovePlugins" $(git grep -l RemovePlugins) No occurrences left? Think of another grep :) Check number of records in plugin_data/methods. Repeat: prove $(git grep -l Koha::Plugin | grep -P "^t\/db") And check number of records again. Same? Bonus: Apply TestMR plugin patch (marked DO NOT PUSH). Run perl -MKoha::Plugins -e"Koha::Plugins->new->InstallPlugins". Check plugin records in database. Keep those records but remove last patch from git. Run previous prove and verify no data changes since last check. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.