https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649 Bug ID: 17649 Summary: Create only one message per borrower and overdue level Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: koha@univ-lyon3.fr QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Following a discussion on french list koha-infos, it appears that, among other ones, 2 things are expected from the overdue_notices.pl script (but not currently achieved) : 1) It should be possible to send only one message grouping all branches overdue items with same delay level => by now there are as much messages sent as overdue items branches with same level ( a patron that have overdue with same level in library A and B will received 2 messages claiming the same items.) This patch try to solve this problem ( provided to use only a default notice model in Notices and Slips). It introduces a new option (a|all_in_one) that has to be followed by a branchcode from which will be set the sender address of the message. 2) each branch should be able to send claims including only its very overdue items => by now messages also include, if they exist, all overdues with same delay level from other branches, even if library option is used. Patch from bug 17470 aims to solve this problem. Test plan (almost entirely and shamefully copied from bug 17470 !) 0/ Have (or create) at least two branches B1 and B2. Have (or create) a default notice for all branches in Notices and Slips Module 1/ Make sure you're logged in with an account belonging to B1, or switch to branch B1 2/ checkout item I1 (belonging to B1) to patron P (preferably while specifying a due date < today) 3/ switch to branch B2 4/ checkout item I2 (belonging to B2) to patron P (preferably while specifying a due date < today) 5/ make sure you have defined "Overdue notice/status triggers" for that patron category, ie with Delay=1 so that "Overdue Notice" is selected and "Email" is checked. 6/ from cli run 'perl ./misc/cronjobs/overdue_notices.pl' (optionally specifying also '-library B1 -library B2') example (say that B2CODE is the branchcode of B2 branch ): ./overdue_notices.pl -t -a B2CODE 7/ Two new entries will be generated in message_queue DB table, coming from different branches that have the SAME list of overdue items 8/ either see the 'content' field in these entries, or run 'perl ./cronjobs/process_message_queue.pl' to receive the actual emails (provided the email is properly setup). Apply patch redo step 6/ You will see that only one message had been created. Its content shows both B1 and B2 overdue items and the sender address matches B2 address as well. Olivier Crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.