https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16873 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54626&action=edit Bug 16873: Improve renewal error messages on self check When a patron is not allowed to renew from the self check module, the only message displayed is "No renewals allowed". It would be nicer to let him/her know that the renewal is not allowed because it's a on-site checkout or automatic renewal. To do so we can call CanBookBeRenewed instead of CanBookBeIssued and get the renewal error. Test plan: 0/ Switch off AllowSelfCheckReturns 1/ check in an item and tick "auto renewal" 2/ Go on the self check module => auto renewal message is displayed 3/ check in an item and tick "on-site checkout" 4/ Go on the self check module => on-site checkout message is displayed 5/ check in an item without ticking any checkboxes (regular checkout) Renew it to reach the max renew allowed 6/ Go on the self check module => regular checkout message is displayed 7/ Switch on AllowSelfCheckReturns and repeat previous steps => "Return this item" button is displayed in addition of the renewal error message -- You are receiving this mail because: You are watching all bug changes.