https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40989 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
refactoring *could* be a pain to support both cases
+1 and if anything to refactor, it would be accommodate the new self_url() output, not both cases. If we can away without wider changes, let's go with that. -- Not related to fixing the tests but still to the change of self_url(), there are other occurrences of self_url() that on recent OSes I guess should lead to URLs with a double / in the middle. That shouldn't be a worry right? Unless we have a specific case that could be a concern. For good measure, I've emailed Matts to know if they think of something when knowing about that self_url() change. Otherwise, test plan works and code looks good so I think I'll pass QA not later than Monday unless some info comes up. -- You are receiving this mail because: You are watching all bug changes.