https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #57 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Nick Clemens (kidclamp) from comment #52)
I believe other calls to CanItemBeRserved should be adjusted or taken into consideration
Both reserve/request.pl and opac/opac-reserve.pl currently call CanItemBeReserved and then call IsAvailableForItemLevelRequest
After this code, if I understand correctly, IsOnShelfHoldsPolicySatisfied will now be called twice for each item - once from CanItem.. and once from IsAvailable..
See bug 32702 - we really need to consolidate these two routines, or if a check is moved into CanItemBeReserved, it should be removed from the other?
there is another bug to merge CanItemBeReserved and IsAvailableForItemLevelRequest in a single function. Also I've seen that most time both functions are called, IsAvailableForItemLevelRequest is only called if CanItemBeReserved is "ok". that makes less calls. -- You are receiving this mail because: You are watching all bug changes.