https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37573 --- Comment #6 from Michał <schodkowy.omegi-0r@icloud.com> --- Test plan: 1. Go to settings and in pref OPACSearchForTitleIn enter this: <script> function test() { console.log("test!"); } test(); </script> 2. Go to OPAC and open some biblio record's page. 3. Open dev tools console (Ctrl+Shift+I). Before applying the patch you should see a syntax error, after applying it you should see "test!" logged.
This fix also seems like a bit of a hack still, as it means your link text couldn't be "Awesome {Library}". Single braces really aren't great for template tokens, but too late to change that now.
I think that's just a matter of adjusting the regex. Allowing lower-case chars would be relatively reasonable if need be. Allowing a bunch of text that's a body of JS code block, constituting of other characters like semicolons and newlines: probably not. -- You are receiving this mail because: You are watching all bug changes.