http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=1162 Summary: Some potential bugs I noticed Product: Koha Version: branch 2.2 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Acquisitions (Simple) AssignedTo: paul.poulain@free.fr ReportedBy: jmf@kados.org QAContact: koha-bugs@nongnu.org additem.pl has two questionable lines: 192, 193 my ($itemtagfield,$itemtagsubfield) = &MARCfind_marc_from_kohafield($dbh,"items.itemnumber"),$itemtype); my ($branchtagfield,$branchtagsubfield) = &MARCfind_marc_from_kohafield($dbh,"items.homebranch"),$itemtype); I believe itemtype is incorrect here, it should be frameworkcode (or actually, left blank in the case of itemnumber I bet). Paul, can you comment on this? Second one is line 214: if (($field->tag eq $branchtagfield) && ($subf[$i][$0] eq $branchtagsubfield) && C4::Context->preference("IndependantBranches")) { Unless I'm mistaken $0 should just be 0, right? Paul, could you take a look and fix it if I'm right? ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.