https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42383 --- Comment #54 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 209605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209605&action=edit Bug 42383: (QA follow-up) Apply barcode filters on check-in by barcode This patch makes POST /checkins run the passed external_id through C4::Circulation::barcodedecode before looking up the item. This applies the itemBarcodeInputFilter system preference and the item_barcode_transform plugin hook, as the legacy circ/returns.pl did. Before this patch, a barcode needing transformation (e.g. one scanned with spaces when itemBarcodeInputFilter is 'whitespace') could not be checked in, and returned a 404. It addresses point 4 of the QA comment. Test plan: 1. Set the itemBarcodeInputFilter system preference to 'Remove spaces from' 2. Check out an item to a patron 3. Go to Circulation > Check in 4. Check in the item, typing its barcode with a space in the middle => FAIL: 'No item with barcode' is displayed 5. Apply this patch and restart plack: $ ktd --shell k$ koha-plack --restart kohadev 6. Repeat 4 => SUCCESS: The item is checked in 7. Run: k$ prove t/db_dependent/api/v1/checkins.t => SUCCESS: Tests pass! 8. Sign off :-D Assisted-by: Opus 5.5 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.