https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092 --- Comment #13 from David Gustafsson <glasklas@gmail.com> --- (In reply to Kyle M Hall from comment #12)
Can you show create a script or test or another way to demonstrate the speed improvement? I used multitime to test and it appears to be a bit slower with your patches. If your code is indeed faster, I'm wondering if the additional cache flushing is causing the issue
Master: 1: prove t/db_dependent/Circulation.t t/db_dependent/Reserves.t t/db_dependent/Biblio.t t/db_dependent/Koha/Charges/Fees.t t/db_dependent/Items.t t/db_dependent/Koha/Patron.t t/db_dependent/api/v1/checkouts.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t Mean Std.Dev. Min Median Max real 41.937 2.340 38.932 41.881 46.608 user 35.524 1.881 33.089 35.399 39.304 sys 4.245 0.429 3.624 4.191 4.969
Both Patches: 1: prove t/db_dependent/Circulation.t t/db_dependent/Reserves.t t/db_dependent/Biblio.t t/db_dependent/Koha/Charges/Fees.t t/db_dependent/Items.t t/db_dependent/Koha/Patron.t t/db_dependent/api/v1/checkouts.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t Mean Std.Dev. Min Median Max real 42.670 2.010 39.200 42.716 45.849 user 35.969 1.485 33.404 35.807 38.477 sys 4.444 0.457 3.742 4.612 5.096
Without the "Fix tests" Patch: 1: prove t/db_dependent/Circulation.t t/db_dependent/Reserves.t t/db_dependent/Biblio.t t/db_dependent/Koha/Charges/Fees.t t/db_dependent/Items.t t/db_dependent/Koha/Patron.t t/db_dependent/api/v1/checkouts.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t Mean Std.Dev. Min Median Max real 41.730 1.535 40.115 41.217 45.135 user 35.400 1.165 34.116 34.928 37.987 sys 4.158 0.345 3.633 4.152 4.908
Circulation rules are rarely (if ever) fetched more than once in those tests, and for the difference to be noticeable you would have to access the rules within some kind of loop iterating over a larger number of items (for example). Don't have a lot of time on my hands right now so providing a script will probably take some time. What I could do meanwhile is to upload a flame graph before and after the patch with the test case have been using. -- You are receiving this mail because: You are watching all bug changes.