https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27859 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #47 from David Gustafsson <glasklas@gmail.com> --- (In reply to David Cook from comment #44)
Comment on attachment 178145 [details] [review] Bug 27859: Export staff interface search results when using Elasticsearch
Review of attachment 178145 [details] [review]: -----------------------------------------------------------------
::: installer/data/mysql/atomicupdate/bug_27859- add_enable_search_result_marc_export_sysprefs.pl @@ +16,5 @@
+ $dbh->do(q{ INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('ElasticsearchSearchResultExportLimit', NULL, NULL, 'Search result export limit', 'integer') }); + say $out "Added new system preference 'ElasticsearchSearchResultExportLimit'"; + + $dbh->do(q{ UPDATE systempreferences SET options = 'base64ISO2709|ARRAY' WHERE variable = 'ElasticsearchMARCFormat' }); + $dbh->do(q{ UPDATE systempreferences SET value = 'base64ISO2709' WHERE variable = 'ElasticsearchMARCFormat' AND value = 'ISO2709' });
I like the idea of changing ISO2709 to base64ISO2709, as it's annoying to translate between base64ISO2709 and ISO2709 (whereas ARRAY and MARCXML can be matched easily). That said... that seems like a different bug report to me. It'll also conflict with bug 28370 if it gets accepted, so we'll want to be careful there.
Did you link to the wrong bug? Seems it has been pushed and is not related. I agree it's not ideal to have the format name change as part of this bug, I just hoped I could sneak it in I suppose. Would be pretty simple to break it out I suppose. The syspref value actually was base64ISO2709 in bug 19893 before it was removed since I believe we didn't want to allow the user to select a less performant format, but was reintroduced in bug 22258 as ISO2709 when the ARRAY format was added. -- You are receiving this mail because: You are watching all bug changes.