https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23849 --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to Jonathan Druart from comment #13)
(In reply to Paul Poulain from comment #11)
Comment on attachment 94426 [details] [review] [review] Bug 23849: [DO NOT PUSH] List of sysprefs we share but not exist in DB
Good job Jonathan ! looking at this list, they used to exist, so there's a value on hea for most of them. So the task is both remove them on Koha side, as well as on HEA
question: version, are you sure it doesn't exist ?
it's because of "version" vs "Version".
(In reply to Paul Poulain from comment #12)
Comment on attachment 94428 [details] [review] [review] Bug 23849: [DO NOT PUSH] List of sysprefs in DB we do not share
Looking at the list, I see that you made an SQL check. There are some sysprefs that we will never share, and even some that we can't share. For example casServerUrl, or BakerTaylorPassword. Where we wrote HEA, we selected only the ones we thought useful. I agree we must update this list, but maybe by checking those who have been introduced since HEA was pushed (and if someone think an old one is missing, then we still can add it)
Yes but it seems easier to redo the whole check and start again with a clean base. See the version of the patches " - comments" to see the ones I have removed from the list.
do you mean https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94429&action=diff ? I've read the diff, most of the lines have a "> no" => does it mean we wouldn't share them on HEA ? (if yes, I agree) The only one that would be added is "AnonymousPatron" (and yes, I think it should be added) Idea : what about adding some statistics like "intranetuserjs yes/no" => yes if there's something, no if it's empty ? (intranetuserjs, opacuserjs, opac & intranet css, opacheader, opacnav, opacbottom). For sysprefs *XSLT* => we could send "empty/default/local". -- You are receiving this mail because: You are watching all bug changes.