http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11621 Bug ID: 11621 Summary: Race condition exists for trapping holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com It is possible to trigger a race condition when it trapping items to fill holds: 1) Librarian A checks in Book 1, which displays the hold trap dialog 2) Librarian B checks in Book 2, which displays the hold trap dialog 3) Librarian A clicks the "confirm and print" button, which prints the hold slip and sends a hold waiting message to the patron 4) Library B clicks the "confirm and print" button, which causes the previous hold to be overwritten with the new hold, and thus Book 1 is no longer a waiting hold for this patron, Book 2 is. 5) Book 1 is now available, and if there are other holds that need filled, none of them will be fulfilled with Book 1 unless a librarian checks it in again. I believe this issue is caused by ModReserveFill assuming the hold must need filled if called, and does not check for an existing waiting reserve. This issue must be addressed in C4::Reserves and not just circ/returns.pl as the issue affects SIP2 hold fulfillment as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.