https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26132 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 108148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108148&action=edit Bug 26132: Remove raw sql query Making use of Koha::Checkouts make the code much more readable here. It fixes 2 flaws: * $type was not quote escaped * the effective itemtype was not used which could lead to wrong calculation (for instance item-level_itypes is set but the item does not have the itype defined) However there is something to note, we are going to make things a bit less effective as we are now fetching the items to get their effective itemtype (vs a SUM done at DB level) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.