https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33987 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Cook from comment #3)
Comment on attachment 152297 [details] [review] Bug 33987 - Combine multiple db updates one in BatchCommitRecords
Review of attachment 152297 [details] [review]: -----------------------------------------------------------------
::: C4/ImportBatch.pm @@ +682,5 @@
$query = "UPDATE import_auths SET matched_authid = ? WHERE import_record_id = ?"; } + # Combine xml update, SetImportRecordOverlayStatus, and SetImportRecordStatus updates into a single update for efficiency, especially in a transaction + my $sth = $dbh->prepare_cached("UPDATE import_records SET marcxml_old = ?, status = ?, overlay_status = ? WHERE import_record_id = ?"); + $sth->execute($oldxml, 'imported', 'match_applied',, $rowref->{'import_record_id'});
Is there a typo on this line? I see two commas in a row?
I removed the second comma. It didnt matter but it should not be there -- You are receiving this mail because: You are watching all bug changes.