http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8829 --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #4)
I agree with the description and the fact that it's critical.
But isn't it caused by the fact that GetAuthorizedHeading isn't exported in C4/AuthoritiesMarc.pm ? Shouldn't we add this sub to expose it (in the .pm) instead of adding a fully qualified name (in ImportBatch) ?
(reminder = in Perl, you can't access a sub in a package unless: - it's exported - you fully qualify it [that's why purists says there's not real OO in Perl, because you can't have a really private method in you object] )
I prefer the fully-qualified name because really GetAuthorizedHeading shouldn't be exported. It should be an object method on Koha::Authority. BuildSummary also should not be exported. However, changing that is a bit more than a bugfix, and I'd prefer not to make master unstable this close to 3.10. -- You are receiving this mail because: You are watching all bug changes.