https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 --- Comment #12 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Emily Lamancusa (emlam) from comment #11)
I'm afraid this has introduced a few new bugs - there are a few places in the code where RevertWaitingStatus was being used to revert other found statuses, which now throw an error 500:
- in request.tt, the "Revert waiting status" button's text changes to "Revert transit status" if the hold is in-transit, but under the hood it's the same code that calls revert_waiting either way
- when checking out an item with a found hold, if the user chooses to revert the status of the hold and check out the item, revert_waiting gets called regardless of which found status the item has
Any reason not to name the method revert_found and explicitly allow it to revert any found status?
Good catch. This is why we need 100% tests coverage in the code. I'll provide a follow-up in a separate bug. -- You are receiving this mail because: You are watching all bug changes.