4 Nov
2024
4 Nov
'24
2:36 p.m.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38342 --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- @ashimema: I have doubts about the handling you added for the 'property' value. Specifically: ``` property => $property =~ /(\w+\.\w+)$/ ? $1 : $property, # results in table.column without quotes or backtics ``` Before that check you added for cleaning it up, there's a use of `$property` as-is for checking the column is of type ENUM. So I feel either my patch is correct, or we might miss some cases for enum types (i.e. the cleanup needs to happen for all uses of `$property`, not just the last one). -- You are receiving this mail because: You are watching all bug changes.