https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #15)
This feels wrong to me.
The pref description: "Note that this number of days will be used too in calculating the default end date for the Holds to pull-report. But it does not interfere with issuing, renewing or transferring items."
It seems that we need a filter_by method, and use it only where it needs this pref to be taken into account.
You are right. We should adjust the wording of that pref. Will add a follow-up. The filter_by comment is valid too. But I dont think that it should be done here. It is an improvement on its own. There are more methods that could be reworked into filter_by constructs. Like for instance: Koha/Biblio.pm current_checkouts Koha/Acquisition/Order.pm current_item_level_holds The point of this report is refine the existing two current_holds methods where the pref should be taken into account. -- You are receiving this mail because: You are watching all bug changes.