https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38338 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #104 from David Cook <dcook@prosentient.com.au> --- Looking back on the comments and history... I'm not sure why I marked this as "Failed QA". I think maybe I was going to provide an alternate option but then decided it would be better to open a different ticket, so that InLibro's work could continue here. I don't think the posted patches are the right way to go. I think that they try to do too much and in a suboptimal way. But I don't want to be a blocker either if others thought this was an optimal way to go. I think bug 42870 is going to be a better route overall because it expands the possibilities with a very minimal change to the status quo. So there's really no risk with it as far as changes go. There's also no reason why the 2 bugs can't go together. As Tomas suggested earlier, bug 38338 could be implemented as a Email::Sender::Transport::SMTP module, and it could stack on top of bug 42870. -- You are receiving this mail because: You are watching all bug changes.