http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13851 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 40039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40039 [SIGNED-OFF] Bug 13851 - Replace waiting holds logic in circulation.pl with Koha Objects Review of attachment 40039: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13851&attachment=40039) ----------------------------------------------------------------- There is a lack of tests for new module added by this patch. ::: Koha/Branches.pm @@ +28,5 @@
+use base qw(Koha::Objects); + +=head1 NAME + +Koha::Branches - Koha Reserve object set class
s/Reserve/Branch ::: Koha/Hold.pm @@ +45,5 @@
+ +sub biblio { + my ($self) = @_; + + $self->{_biblio} ||= Koha::Biblios->find( $self->biblionumber() );
Why not return $self->{_result}->biblio; ? @@ +59,5 @@
+ +sub item { + my ($self) = @_; + + $self->{_item} ||= Koha::Items->find( $self->itemnumber() );
Same as before. @@ +73,5 @@
+ +sub branch { + my ($self) = @_; + + $self->{_branch} ||= Koha::Branches->find( $self->branchcode() );
Same as before. ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @@ +763,5 @@
+ [% IF ( WaitingHolds ) %] + <div id="holdswaiting" class="circmessage"> + <h4>Holds waiting:</h4> + [% FOREACH w IN WaitingHolds %]
WaitingHolds is an array?? You have passed WaitingHolds => scalar $holds->waiting() in the pl script. -- You are receiving this mail because: You are watching all bug changes.