https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Ok, a few comments: - If you add parameters to a koha-* script, you need to add them to the docs in debian/docs/koha-* as well. This is a blocker, so FQA Also - I don't 100% understand how the uploaded tmp files will be differentiated from any other file in tmp. The 'get_tmp_path' function name in koha-functions.sh raised my suspicion, as it doesn't mention 'upload' or 'uploaded'. This could be revisited too. - I have the feeling that in order to make this more useful for production, we could try thinking how this could be used from koha-run-backups. When I added the 'exclude_indexes' option switch to koha-dump, I also added it to koha-run-backups. In this case it is not a flag (yes/no) but a string parameter with a path, so it doesn't sound like a straight-forward addition. But... maybe an option switch to include/not include uploads on the backup? Food for thougth, not a blocker. -- You are receiving this mail because: You are watching all bug changes.