https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35828 --- Comment #8 from Magnus Enger <magnus@libriotech.no> --- (In reply to Magnus Enger from comment #7)
Test plan: 1) Before applying the patch, simulate a system without the plugin in KTD: sudo mv /usr/lib/x86_64-linux-gnu/perl5/5.40/Template/Plugin/CGI.pm /tmp/ restart_all 2) Visit both pages, notice the 500 errors: http://localhost:8081/cgi-bin/koha/serials/serials-search.pl http://localhost:8081/cgi-bin/koha/patroncards/manage.pl?card_element=layout 3) Apply patch, restart_all 4) Visit both pages again, they load fine
OK!
5) Create a subscription if you don't have one ('Serials' > 'New subscription') 6) Search subscriptions using 'Title' and 'Library', tick the result, click 'Edit selected serials' 7) Click 'Cancel', you're back on the same results with your filters
Not sure I understand this. I added two serials. When I search for them, the URL is http://localhost:8081/cgi-bin/koha/serials/serials-search.pl?ISSN_filter=&title_filter=&callnumber_filter=&publisher_filter=&bookseller_filter=&branch_filter=&location_filter=&expiration_date_filter=&searched=1 and both serials are shown. When I select them and click on 'Edit selected serials' I am sent here: http://localhost:8081/cgi-bin/koha/serials/subscription-batchedit.pl?referrer=&subscriptionid=2&subscriptionid=1 The link behind the "Cancel" label is the same: http://localhost:8081/cgi-bin/koha/serials/subscription-batchedit.pl?referrer=&subscriptionid=2&subscriptionid=1 So clikcing on "Cancel" does not really do anything.
8) Repeat 6), fill in 'Public note', click 'Save' 9) You're back on the same results with your filters, and the note is saved (note the ';' separators in the address bar)
No, this sends me back to http://localhost:8081/cgi-bin/koha/serials/serials-home.pl with an empty search form. There are no ';' separators in the URL. I consider 1-4 to be the most important part of this, so since this part works I have signed off the patch. -- You are receiving this mail because: You are watching all bug changes.