https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com Status|Signed Off |Failed QA --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Thanks for adding the test. I am not yet fully comfortable with the code added to MsgType.pm. I would rather have the validation in Patron.pm and just calling $patron->validate_or_something from MsgType. Also the current code needs additional checking. If a patron is already debarred etc, so charge_ok is already 0, we should not set charge_ok to 1 only because the validation attribute is present. Another point (no blocker, but adding to discussion): Is the test attr==1 not too simple? Could we allow something like validate_patron="opendoor=Y" or even two expr like validate_patron="opendoor=Y;categorycode=X" etc.? Could be a future extension.. Copying Coling: Do you have additional feedback ? Changing status -- You are receiving this mail because: You are watching all bug changes.