https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42396 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201174&action=edit Bug 42396: Remove C4::Stats::UpdateStats and delete module This patch replaces all calls to C4::Stats::UpdateStats with the wrapped function from the Koha namespace. As this is the last function in C4::Stats, the module is also deleted. Several tests depended on transitive includes to Koha::Statistics through C4::Stats. I've identified uses of that module by searching, and added the necessary use in each case. I've run `prove -r t xt` with this patch applied and didn't hit any relevant errors. Test plan: 1. Inspect the patch, and verify each changed call maintains the same parameters. 2. Apply patch. 3. Prove the following files: - t/db_dependent/Accounts.t - t/db_dependent/Circulation.t - t/db_dependent/Koha/Account.t - t/db_dependent/Koha/ILL/Request.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Pseudonymization.t - t/db_dependent/Koha/Recalls.t Sponsored-by: Open Fifth Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.