https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24715 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #17)
(In reply to Jonathan Druart from comment #16)
I think I understand what you are trying to do but, did you benchmark it?
You a putting in a variable something that is L1 cached, then retrieved from there without deep copy.
I am really not sure it is needed.
Yeah, using the unsafe parameter as done elsewhere. About cache/benchmarking, see bug 21800 comment 12. I added it on request. Note that I only check the framework if it is really needed. So when we actually get a repeated value in a field.
I am not against the unsafe parameter. My concern is more about the usefulness of the $mss2 trick. I have the conviction that is not needed, retrieving $mss (framework specific in _check_split) from the L1 cache should be the only thing you need here. Basically the patch could only be: # here we need to check the specific framework my $mss = GetMarcSubfieldStructure($params->{framework}, { unsafe => 1 }); foreach my $fld2 ( @{ $mss->{ $fld->{kohafield} } } ) { next if $fld2->{tagfield} ne $fld->{tagfield}; next if $fld2->{tagsubfield} ne $fld->{tagsubfield}; return 1 if $fld2->{repeatable}; } -- You are receiving this mail because: You are watching all bug changes.