https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The 2 Koha::Database->new->schema->resultset( $self->_type )->search call sounds weird to me. It looks like you need to create a new method to return the type of the attribute (so return a the Koha::Patron::Attribute::Type related to $self->code). Don't you think? That will simplify the code and make it more readable. Switch back to SO if you disagree or if I am missing something. -- You are receiving this mail because: You are watching all bug changes.