https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40569 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA Version|unspecified |Main CC| |caroline.cyr-la-rose@inlibr | |o.com Assignee|koha-bugs@lists.koha-commun |slavashishkin@gmail.com |ity.org | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) QA checks - all pass! 2) Code review I don't believe this is the right fix. It adds quoting, but it removed the URL encoding that I believe is also needed: - <a><xsl:attribute name="href"><xsl:value-of select="$searchurl"/>?q=se,phr:"<xsl:value-of select="str:encode-uri(marc:subfield[@code='a'], true())"/>"</xsl:attribute> + <a><xsl:attribute name="href"><xsl:value-of select="$searchurl"/>?q=se,phr:<xsl:call-template name="quote_search_term"> + <xsl:with-param name="term"><xsl:value-of select="marc:subfield[@code='a']"/></xsl:with-param> + </xsl:call-template> + </xsl:attribute> quote_search_term only adds " and escapes quotes in the string. Hope I am not missing something. 3) Other I notice that the sign-off line for Noah could be a little nicer :) Signed-off-by: noah <noah@inlibro.com> Added assignee. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.