https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371 --- Comment #66 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Better in only one comment: 1. We don't need the weird "Koha::Exceptions::UnknownProgramState" exception, C4::Context->interface() is always returning something. 2. There are still occurrences of GetDailyQuote in t/db_dependent/Koha.t (the tests are failing) 3. The methods from Koha::Quote must be in Koha::Quotes 4. +use DBI qw(:sql_types); We don't need that 5. You are adding raw SQL queries in Koha namespace, that is not needed. 6. After 5, DateTime::Format::MySQL become useless 7. I don't think we need the 2 methods in Koha::Quotes, could be only 1, get_daily_quote -- You are receiving this mail because: You are watching all bug changes.