https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16631 Casey Conlin - mattermost @Casey246 <casey.conlin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #146 from Casey Conlin - mattermost @Casey246 <casey.conlin@gmail.com> --- The patch was updated to address Andrew's comments below. - Where you've used the term "branch," you should instead use "library" (https://wiki.koha-community.org/wiki/Terminology) - When the LimitReportsByBranch system preference is enabled, reports created by users without manage_report_limits permission should default to being limited to the library of the user The terms have been updated for public facing UI, and for the preference. We continue to use "branch" in the code consistent with the rest of the codebase. Logic has been added so that reports created by non-permissioned users are limited to that user's home library. Limits are not changed when non-permissioned users edit a report to avoid overwriting limits intentionally set by permissioned users. Unit tests were added and the test plan was updated to include the updated functionality. Thank you for the feedback, and please let me know if there are any questions. -- You are receiving this mail because: You are watching all bug changes.