https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988 --- Comment #13 from David Cook <dcook@prosentient.com.au> --- Overall, it works pretty well! If you fix the atomic update and the text/styling, I think I'd be happy to sign this off. QA might knock it back because of the lack of unit tests though. It would be a good idea to move a lot of the code out of "opac/svc/auth/openidconnect" and into a Koha/Auth/Client/OIDC module. -- Also, I'm getting these warnings in the logs for failed logins (I had some issues initially setting up my Keycloak which caused some failures): [2022/06/21 00:02:03] [WARN] Useless use of private variable in void context at /kohadevbox/koha/opac/svc/auth/openidconnect line 90. [2022/06/21 00:02:03] [WARN] Useless use of anonymous hash ({}) in void context at /kohadevbox/koha/opac/svc/auth/openidconnect line 90. -- You are receiving this mail because: You are watching all bug changes.