https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |tomascohen@gmail.com --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm failing this one: - Fixing data types and providing and extension for Koha::Object to handle some inconsistencies are different concerns. And bug 17926 provides a more simple way of doing it. - If you still feel we need to make Koha::Object handle data transformations suitable for output on the REST api, please file a new bug. We still need to openly discuss two things: mistakes in our DB model, and the fact that user facing REST apis don't need to be tied to the underlying model. - Many of the type fixes are correct, but we need to make booleans be booleans, and this patch fails to do so, making them integers. I still think we could make use of the column-to-swagger table, but I'm not sure how to deal with Booleans (which are wrongly mapped to integers currently in most of the cases, as there are only a dozen cases in which they are really integers). I'm open to discuss this on separate bugs that don't catch-them-all. So I'm closing this one, and available to help resurrect the ideas behind this bug. -- You are receiving this mail because: You are watching all bug changes.