https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #114 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Issue 1: attributes from non-first class silently vanish on the patron detail page 1) Add two attribute types, each with a different "Class", e.g. code AAA_ATTR with class AAA, and code ZZZ_ATTR with class ZZZ: http://localhost:8081/cgi-bin/koha/admin/patron-attr-types.pl?op=add_form 2) Edit patron 19, go to "Additional attributes and identifiers", fill in a value for both AAA_ATTR and ZZZ_ATTR, save: http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=19 3) Open that patron's detail page: http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=19 => Expected: both attributes show their values, grouped under "AAA" and "ZZZ". Actual: the "ZZZ" section heading appears, but it's empty, ZZZ_ATTR's value is not shown underneath it, even though it was saved. Issue 2: dead code (code-inspection only, no UI path) Run: grep -rn "patron_attributes_form" --include=*.pl --include=*.pm --include=*.t . Koha::Patron::Attribute::Types::patron_attributes_form(...) gets called several times. The separate sub patron_attributes_form { defined inside memberentry.pl never appears as a call anywhere, only its own definition. => Those 72 lines are never executed, dead code added in the first commit and never used since -- You are receiving this mail because: You are watching all bug changes.