https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 95654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95654 Bug 24075: Backdating a return to the exact due date and time results in the fine not being refunded Review of attachment 95654: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=24075&attachment=95654) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +1966,4 @@
MarkIssueReturned( $borrowernumber, $item->itemnumber, $return_date, $patron->privacy ); }; unless ( $@ ) { + if ( $return_date_is_forced || ( C4::Context->preference('CalculateFinesOnReturn') && $is_overdue && !$item->itemlost ) ) {
This feels somewhat wrong.. I'm sure Katrin would say "But we don't ever want to recalculate fines if we have 'CalculateFinesOnReturn' turned off" So.. could this perhaps be: `if ( C4::Context->preference('CalculateFinesOnReturn') && ($return_date_is_forced || $is_overdue) && !$item->itemlost ) {` Instead? -- You are receiving this mail because: You are watching all bug changes.