https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40671 Bug ID: 40671 Summary: Rename `revert_waiting` => `revert_found` in Koha::Hold Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org The original method -RevertWaitingStatus- was actually used to revert any `found` status, not just waiting. The `Koha::Hold->revert_waiting()` method implemented on bug 40058 throws an exception if the hold is not waiting. This causes errors in a couple places (reverting in transit holds, reverting in processing holds, etc). We need to document things better and cover all the use cases with tests to avoid this. Will do my best. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.