https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43896 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 208832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208832&action=edit Bug 43896: Patrons can't log in with a cardnumber that matches another patron's userid Bug 40286 made checkpw_internal use Koha::Patrons->find_by_identifier, which only returns the userid match when an identifier is one patron's userid and another patron's cardnumber. Before that, Koha tried the userid match and then the cardnumber match. Now the cardnumber owner can't log in with their own password, and each attempt counts as a failed login on the other patron. This patch restores the cardnumber fallback when the password doesn't match. Test Plan: 1) Apply the unit test patch 2) prove t/db_dependent/Auth.t 3) Note the test failures 4) Apply this patch 5) prove t/db_dependent/Auth.t 6) All tests pass! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.